Bump windows-sys version to 0.59 #133
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
faern
requested changes
Oct 22, 2024
|
This apparently bumps the MSRV. So you need to update the CI to run on 1.60.0 instead of 1.58.0. See the comment in |
|
I've updated the MSRV, and tested that both |
|
You need to update what Rust version the CI runs on. It still runs on 1.58. Please see https://github.com/mullvad/windows-service-rs/blob/main/.github/workflows/build-and-test.yml#L24-L28 Also don't forget my comment about the documentation links invalidly pointing to |
|
Ahahah, I must still have been a bit tired in the morning. Forgot to actually add the files before committing. Here you go. |
faern
approved these changes
Oct 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This updates the windows-sys version to 0.59.
This change is