Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make the network JSON uploader more flexible and allow JSON table uploads #150

Merged
merged 9 commits into from
Feb 28, 2023

Conversation

JackWilb
Copy link
Member

@JackWilb JackWilb commented Feb 18, 2023

Does this PR close any open issues?

Closes #124

Give a longer description of what this PR addresses and why it's needed

This makes it so json networks that define either _key or id as node identifier and either _from and _to or source and target can be uploaded. This means that it's possible to upload data as we use it in mulinet or as it is used in D3. Another benefit of this is that data that is downloaded from the client is now upload-able again.

I'm also planning to enable JSON uploads of tables so that the downloaded versions of the tables can be uploaded.

Provide pictures/videos of the behavior before and after these changes (optional)

N/A

Are there any additional TODOs before this PR is ready to go?

TODOs:

@JackWilb JackWilb changed the title Make the d3 uploader take _key for node, and _to and _from for edges Make the network JSON uploader more flexible and allow JSON table uploads Feb 18, 2023
@JackWilb JackWilb merged commit 8789de7 into main Feb 28, 2023
@JackWilb JackWilb deleted the upload-downloads branch February 28, 2023 22:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Network download endpoint doesn't return a re-uploadable network
1 participant