Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add option to enable loop back on external interfaces #6

Merged
merged 1 commit into from
Dec 21, 2023

Conversation

relativityspace-vtang
Copy link
Collaborator

By default multicast_expert will ignore self-reception of packets sent on external/non-loopback interfaces. This PR adds the ability to override the default behavior and receive multicast packets sent over external/non-loopback interfaces.

This PR adds the enable_external_loopback parameter to both McastRxSocket and McastTxSocket initializers. When enable_external_loopback is True, multicast_expert will be able to receive multicast packets sent with an external, non-loopback interface.

Copy link
Owner

@multiplemonomials multiplemonomials left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good! Just a few minor things to fix

multicast_expert/rx_socket.py Outdated Show resolved Hide resolved
multicast_expert/rx_socket.py Outdated Show resolved Hide resolved
multicast_expert/tx_socket.py Outdated Show resolved Hide resolved
tests/test_multicast_expert.py Show resolved Hide resolved
@relativityspace-jsmith relativityspace-jsmith merged commit 412188a into main Dec 21, 2023
36 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants