Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build cleanup #807

Merged
merged 2 commits into from
Jan 8, 2024
Merged

Build cleanup #807

merged 2 commits into from
Jan 8, 2024

Conversation

ovidiuolteanu
Copy link
Contributor

Remade cargo.lock and .toml files to reflect latest framework version.
Actions update to use the latest rust version.

Copy link

github-actions bot commented Jan 5, 2024

Contract comparison - from 1fb9a1d to d352c9b

Path                                                                                             size                  has-allocator                     has-format
mx-exchange-sc
- pause-all/pause-all.wasm 5452 ➡️ 5548 🔴 No No
mx-exchange-sc/dex
- farm/farm.wasm 38868 ➡️ 38759 🟢 No No
- farm-with-locked-rewards/farm-with-locked-rewards.wasm 38501 ➡️ 38439 🟢 No No
- governance/governance.wasm 17305 ➡️ 17355 🔴 No No
- pair
- - pair.wasm 31232 ➡️ 31107 🟢 No No
- - pair-full.wasm 32686 ➡️ 32503 🟢 No No
- - safe-price-view.wasm 7862 ➡️ 7888 🔴 No No
- pair-mock/pair-mock.wasm 5474 ➡️ 5470 🟢 No No
- price-discovery/price-discovery.wasm 16384 ➡️ 16381 🟢 No No
- proxy-deployer/proxy-deployer.wasm 4477 ➡️ 4502 🔴 No No
- router/router.wasm 26617 ➡️ 26718 🔴 No No
mx-exchange-sc/energy-integration
- energy-factory-mock/energy-factory-mock.wasm 4233 ➡️ 4277 🔴 No No
- energy-update/energy-update.wasm 1520 ➡️ 1558 🔴 No No
- fees-collector/fees-collector.wasm 18766 ➡️ 18953 🔴 No No
- governance-v2/governance-v2.wasm 16727 ➡️ 16607 🟢 No No
mx-exchange-sc/farm-staking
- farm-staking/farm-staking.wasm 42992 ➡️ 43079 🔴 No No
- farm-staking-proxy/farm-staking-proxy.wasm 19403 ➡️ 19394 🟢 No No
- metabonding-staking/metabonding-staking.wasm 10158 ➡️ 10176 🔴 No No
mx-exchange-sc/locked-asset
- distribution/distribution.wasm 14379 ➡️ 14292 🟢 No No
- energy-factory/energy-factory.wasm 35393 ➡️ 35029 🟢 No No
- factory/factory.wasm 30399 ➡️ 30470 🔴 No No
- lkmex-transfer/lkmex-transfer.wasm 11235 ➡️ 11262 🔴 No No
- locked-token-wrapper/locked-token-wrapper.wasm 14425 ➡️ 14555 🔴 No No
- proxy_dex/proxy_dex.wasm 36899 ➡️ 36917 🔴 No No
- simple-lock/simple-lock.wasm 24592 ➡️ 24491 🟢 No No
- simple-lock-whitelist/simple-lock-whitelist.wasm 26239 ➡️ 26212 🟢 No No
- token-unstake/token-unstake.wasm 14255 ➡️ 14292 🔴 No No

Copy link
Contributor

@andreibancioiu andreibancioiu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

An extra workflow to simulate releases / reproducible builds can also be helpful. E.g.

https://github.com/multiversx/mx-contracts-rs/blob/main/.github/workflows/on_pull_request_build_contracts.yml

@ovidiuolteanu ovidiuolteanu merged commit e4b95af into main Jan 8, 2024
4 checks passed
@ovidiuolteanu ovidiuolteanu deleted the build-cleanup branch January 8, 2024 09:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants