Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

remove starts with erd check for valid addresses #1267

Merged
merged 4 commits into from
Sep 23, 2024
Merged

remove starts with erd check for valid addresses #1267

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
15a1895
remove starts with erd check for valid addresses
andreigiura Sep 23, 2024
e1ac9da
changelog
andreigiura Sep 23, 2024
b5a741f
2.40.7
andreigiura Sep 23, 2024
9ef416d
Merge branch 'main' into development
andreigiura Sep 23, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,9 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0

## [Unreleased]

## [[v2.40.7]](https://github.com/multiversx/mx-sdk-dapp/pull/1267)] - 2024-09-23
- [Remove hardcoded "erd" check when validating an address](https://github.com/multiversx/mx-sdk-dapp/pull/1267)


## [[v2.40.6]](https://github.com/multiversx/mx-sdk-dapp/pull/1266)] - 2024-09-20
- [Update passkey provider in order to fix passkey login](https://github.com/multiversx/mx-sdk-dapp/pull/1266)
Expand Down
2 changes: 1 addition & 1 deletion package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "@multiversx/sdk-dapp",
"version": "2.40.6",
"version": "2.40.7",
"description": "A library to hold the main logic for a dapp on the MultiversX blockchain",
"author": "MultiversX",
"license": "GPL-3.0-or-later",
Expand Down
4 changes: 1 addition & 3 deletions src/utils/account/addressIsValid.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,9 +11,7 @@ function canTransformToPublicKey(address: string) {

export function addressIsValid(destinationAddress: string) {
const isValidBach =
destinationAddress?.startsWith('erd') &&
destinationAddress.length === 62 &&
/^\w+$/.test(destinationAddress);
destinationAddress.length === 62 && /^\w+$/.test(destinationAddress);

return isValidBach && canTransformToPublicKey(destinationAddress);
}
Loading