FIX(client): Disable broken shortcuts on Wayland #5307
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The EnvUtils class only served as a namespace (containing static functions). Thus, it makes more sense to convert EnvUtils into an actual namespace.
This new function allows to check whether Wayland is being used as the display manager.
Our global shortcut system currently doesn't work when using Wayland (mumble-voip#5257). Therefore, this commit makes sure that the global shortcut system is not even started on such systems. Furthermore, it informs the user about the shortcuts being disabled. Fixes mumble-voip#5303
Krzmbrzl
force-pushed
the
feat-disable-shortcuts-on-wayland
branch
from
c268492
to
7a0227a
Compare
1 task
Krzmbrzl
added a commit
to Krzmbrzl/mumble
that referenced
this pull request
May 18, 2022
In mumble-voip#5307 we disabled global shortcuts on Wayland, but we did it in a way that would prevent anyone from re-enabling the support. Since we have received reports of some users actually making use of the shortcut system on Wayland, even without proper Wayland support, we decided to remove the hard-lock and allow these users to re-enable the shortcuts, if they so want. Fixes mumble-voip#5454
1 task
Krzmbrzl
added a commit
to Krzmbrzl/mumble
that referenced
this pull request
May 23, 2022
In mumble-voip#5307 we disabled global shortcuts on Wayland, but we did it in a way that would prevent anyone from re-enabling the support. Since we have received reports of some users actually making use of the shortcut system on Wayland, even without proper Wayland support, we decided to remove the hard-lock and allow these users to re-enable the shortcuts, if they so want. Fixes mumble-voip#5454
Krzmbrzl
added a commit
to Krzmbrzl/mumble
that referenced
this pull request
Jul 31, 2022
In mumble-voip#5307 we disabled global shortcuts on Wayland, but we did it in a way that would prevent anyone from re-enabling the support. Since we have received reports of some users actually making use of the shortcut system on Wayland, even without proper Wayland support, we decided to remove the hard-lock and allow these users to re-enable the shortcuts, if they so want. Fixes mumble-voip#5454
Krzmbrzl
added a commit
that referenced
this pull request
Jul 31, 2022
In #5307 we disabled global shortcuts on Wayland, but we did it in a way that would prevent anyone from re-enabling the support. Since we have received reports of some users actually making use of the shortcut system on Wayland, even without proper Wayland support, we decided to remove the hard-lock and allow these users to re-enable the shortcuts, if they so want. Fixes #5454
Krzmbrzl
added a commit
to Krzmbrzl/mumble
that referenced
this pull request
Aug 10, 2022
In mumble-voip#5307 we disabled global shortcuts on Wayland, but we did it in a way that would prevent anyone from re-enabling the support. Since we have received reports of some users actually making use of the shortcut system on Wayland, even without proper Wayland support, we decided to remove the hard-lock and allow these users to re-enable the shortcuts, if they so want. Fixes mumble-voip#5454 (cherry picked from commit 49cc697)
Krzmbrzl
added a commit
to Krzmbrzl/mumble
that referenced
this pull request
Aug 10, 2022
In mumble-voip#5307 we disabled global shortcuts on Wayland, but we did it in a way that would prevent anyone from re-enabling the support. Since we have received reports of some users actually making use of the shortcut system on Wayland, even without proper Wayland support, we decided to remove the hard-lock and allow these users to re-enable the shortcuts, if they so want. Fixes mumble-voip#5454 (cherry picked from commit 49cc697)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Our global shortcut system currently doesn't work when using Wayland
(#5257). Therefore, this
commit makes sure that the global shortcut system is not even started
on such systems. Furthermore, it informs the user about the shortcuts
being disabled.
Fixes #5303
Checks