Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

FEAT(plugin-api): Add function to mumble api to obtain current positional audio data provided by another plugin #6556

Draft
wants to merge 7 commits into
base: master
Choose a base branch
from
Draft

FEAT(plugin-api): Add function to mumble api to obtain current positional audio data provided by another plugin #6556

wants to merge 7 commits into from

Commits on Sep 18, 2024

  1. Has some issues, like the documentation of the function currently doe… 

    …sn't match as it doesn't copy/write the data to `void *positionalData` pointer as when looking up cloning, wasn't sure how to achieve it.
    @JordanPlayz158
    JordanPlayz158 committed Sep 18, 2024
    Configuration menu
    Copy the full SHA
    6a8d789 View commit details
    Browse the repository at this point in the history

Commits on Sep 19, 2024

  1. Removes explicit fetching of positional data

    @JordanPlayz158
    JordanPlayz158 committed Sep 19, 2024
    Configuration menu
    Copy the full SHA
    ad56c6d View commit details
    Browse the repository at this point in the history

  2. Removed use of auto from pluginManager declaration to conform to codi… 

    …ng guidelines.
    @JordanPlayz158
    JordanPlayz158 committed Sep 19, 2024
    Configuration menu
    Copy the full SHA
    bec426b View commit details
    Browse the repository at this point in the history

  3. Got getPositionalAudioData working following recommendations (making … 

    …a struct for data transfer)
    @JordanPlayz158
    JordanPlayz158 committed Sep 19, 2024
    Configuration menu
    Copy the full SHA
    890561f View commit details
    Browse the repository at this point in the history

Commits on Sep 20, 2024

  1. Changed strcpy of char *'s to memcpy as recommended as size is known,… 

    … switched to static casts as recommended
    @JordanPlayz158
    JordanPlayz158 committed Sep 20, 2024
    Configuration menu
    Copy the full SHA
    944fa2f View commit details
    Browse the repository at this point in the history

Commits on Sep 26, 2024

  1. Changed positionalData function argument to more clear name expressin… 

    …g its purpose. (outPositionalData)
    @JordanPlayz158
    JordanPlayz158 committed Sep 26, 2024
    Configuration menu
    Copy the full SHA
    d83226c View commit details
    Browse the repository at this point in the history

  2. Added method for properly freeing the positional data struct, althoug… 

    …h as mentioned in code comment, could not get C++ destructor working
    @JordanPlayz158
    JordanPlayz158 committed Sep 26, 2024
    Configuration menu
    Copy the full SHA
    9ad2a82 View commit details
    Browse the repository at this point in the history