jack: add timestamps to debug logs #1285
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Having timestamps showing at which point in time `Muse4` did encounter which JACK position and triggered which API call is of massive help when correlating the logs with behavior/output of other applications. The resulting format will look like this ``` [10:20:00.064] timebase_callback is new_pos:1 nframes:512 frame:0 tickPos:0 cpos:0 [10:20:01.062] JackAudioDevice::setMaster val:1 unconditional:0 [10:20:01.067] timebase_callback() state:0 [10:20:01.067] timebase_callback BBT: bar:1 beat:1 tick:0 bar_start_tick:0.000000 beats_per_bar:4.000000 beat_type:4.000000 ticks_per_beat:384.000000 beats_per_minute:120.000000 [10:20:01.067] pos_to_jack_position new: bar:1 beat:1 tick:0 bar_start_tick:0.000000 beats_per_bar:4.000000 beat_type:4.000000 ticks_per_beat:384.000000 beats_per_minute:120.000000 ``` Personally, I am more a fan of wrapping the log code in a function call than a multiline macro, but I did not wanted refactor your code (without asking first)
|
this is a good idea |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Having timestamps showing at which point in time
Muse4did encounter which JACK position and triggered which API call is of massive help when correlating the logs with behavior/output of other applications.The resulting format will look like this
Personally, I am more a fan of wrapping the log code in a function call than a multiline macro, but I did not wanted refactor your code (without asking first).