Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace @distube/ytdl-core package with yt-dlp binary #1198

Closed
wants to merge 1 commit into from

Conversation

Nerijusas
Copy link

Closes #1166 #1171 #1173

Changelog:

  • Replaced @distube/ytdl-core package with yt-dlp binary
  • Updated README.md to note that yt-dlp binary is required prerequisite for Muse to work
  • Updated Dockerfile to install new yt-dlp prerequisite
  • Updated fluent-ffmpeg package to 2.1.3 version to add support for FFmpeg >5 versions

Downside of this that yt-dlp doesn't provide loudness_db property which was previously used to normalize audio between YouTube videos therefore this functionality will stop working in Muse.

@Nerijusas Nerijusas changed the title Replace '@distube/ytdl-core' package with yt-dlp binary Replace @distube/ytdl-core package with yt-dlp binary Jan 25, 2025
@codetheweb
Copy link
Collaborator

📦 🤖 A new release has been made for this pull request.

To play around with this PR, pull ghcr.io/museofficial/muse:pr-1198.

Images are available for x86_64 and ARM64.

Latest commit: 48d7155

@Cosmo121
Copy link

I still get the following using this pr

WARNING: @distube/ytdl-core is out of date! Update with "npm install @distube/ytdl-core@latest".

WARNING: Could not parse n transform function.

Please report this issue with the "1737851125592-base.js" file on https://github.com/distubejs/ytdl-core/issues.

@Nerijusas
Copy link
Author

Nerijusas commented Jan 26, 2025

I still get the following using this pr

WARNING: @distube/ytdl-core is out of date! Update with "npm install @distube/ytdl-core@latest".

WARNING: Could not parse n transform function.

Please report this issue with the "1737851125592-base.js" file on https://github.com/distubejs/ytdl-core/issues.

Can anyone else confirm this because I cannot reproduce this?

@JoeWHoward
Copy link
Contributor

Please try ghcr.io/museofficial/muse:pr-1197, as @distube/ytdl-core has been upgraded and that seems to fix the problem. I would prefer not to offload yt-dlp requirement to users as a pre-req if we can avoid it. Raising a PR to update Changelog soon so we can push a release.

@Cosmo121
Copy link

Agreed, 1197 working for me. Docker on Rocky

@Nerijusas
Copy link
Author

I'm closing this as there is already working fix with @distube/ytdl-core package

@Nerijusas Nerijusas closed this Jan 27, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Muse joins vc, but doesn't play any music
4 participants