Version-lock rubocop and fix most failing cops

As this gem supports all ruby versions >= 2.0, fix rubocop version to 0.50 (the last version supporting ruby 2.0).

Also fix all auto-correctable and/or superficial cops.

Remove `Gemfile.lock` from `.gitignore` (per kamui#94) and commit working lockfile.

.gitignore

@@ -1,6 +1,5 @@
 /.bundle/
 /.yardoc
-/Gemfile.lock
 /_yardoc/
 /coverage/
 /doc/

.rubocop.yml

@@ -1,3 +1,7 @@
+inherit_from: .rubocop_todo.yml
+AllCops:
+  TargetRubyVersion: 2.0
+
 Style/StringLiterals:
   EnforcedStyle: double_quotes
 

.rubocop_todo.yml

@@ -0,0 +1,21 @@
+# This configuration was generated by
+# `rubocop --auto-gen-config`
+# on 2020-12-28 23:59:17 -0500 using RuboCop version 0.50.0.
+# The point is for the user to remove these configuration records
+# one by one as the offenses are removed from the code base.
+# Note that changes in the inspected code, or installation of new
+# versions of RuboCop, may require this file to be generated again.
+
+# Offense count: 1
+Metrics/CyclomaticComplexity:
+  Max: 14
+
+# Offense count: 2
+# Configuration parameters: AllowHeredoc, AllowURI, URISchemes, IgnoreCopDirectives, IgnoredPatterns.
+# URISchemes: http, https
+Metrics/LineLength:
+  Max: 202
+
+# Offense count: 1
+Metrics/PerceivedComplexity:
+  Max: 15

Gemfile

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 source "https://rubygems.org"
 
 gemspec
@@ -8,7 +10,8 @@ group :test do
 end
 
 group :development do
-  gem "rubocop"
+  gem "rubocop", ">= 0.50", "< 0.51", require: false
+  gem "rubocop-rspec", "~> 1.18.0", require: false
 end
 
 group :development, :test do

Gemfile.lock

@@ -0,0 +1,76 @@
+PATH
+  remote: .
+  specs:
+    retriable (3.1.2)
+
+GEM
+  remote: https://rubygems.org/
+  specs:
+    ast (2.4.1)
+    coderay (1.1.3)
+    diff-lcs (1.4.4)
+    docile (1.3.4)
+    ffi (1.14.2)
+    listen (3.3.3)
+      rb-fsevent (~> 0.10, >= 0.10.3)
+      rb-inotify (~> 0.9, >= 0.9.10)
+    method_source (1.0.0)
+    parallel (1.20.1)
+    parser (2.7.2.0)
+      ast (~> 2.4.1)
+    powerpack (0.1.3)
+    pry (0.13.1)
+      coderay (~> 1.1)
+      method_source (~> 1.0)
+    rainbow (2.2.2)
+      rake
+    rake (13.0.3)
+    rb-fsevent (0.10.4)
+    rb-inotify (0.10.1)
+      ffi (~> 1.0)
+    rspec (3.10.0)
+      rspec-core (~> 3.10.0)
+      rspec-expectations (~> 3.10.0)
+      rspec-mocks (~> 3.10.0)
+    rspec-core (3.10.1)
+      rspec-support (~> 3.10.0)
+    rspec-expectations (3.10.1)
+      diff-lcs (>= 1.2.0, < 2.0)
+      rspec-support (~> 3.10.0)
+    rspec-mocks (3.10.1)
+      diff-lcs (>= 1.2.0, < 2.0)
+      rspec-support (~> 3.10.0)
+    rspec-support (3.10.1)
+    rubocop (0.50.0)
+      parallel (~> 1.10)
+      parser (>= 2.3.3.1, < 3.0)
+      powerpack (~> 0.1)
+      rainbow (>= 2.2.2, < 3.0)
+      ruby-progressbar (~> 1.7)
+      unicode-display_width (~> 1.0, >= 1.0.1)
+    rubocop-rspec (1.18.0)
+      rubocop (>= 0.50.0)
+    ruby-progressbar (1.10.1)
+    simplecov (0.20.0)
+      docile (~> 1.1)
+      simplecov-html (~> 0.11)
+      simplecov_json_formatter (~> 0.1)
+    simplecov-html (0.12.3)
+    simplecov_json_formatter (0.1.2)
+    unicode-display_width (1.7.0)
+
+PLATFORMS
+  ruby
+
+DEPENDENCIES
+  bundler
+  listen (~> 3.1)
+  pry
+  retriable!
+  rspec
+  rubocop (>= 0.50, < 0.51)
+  rubocop-rspec (~> 1.18.0)
+  simplecov
+
+BUNDLED WITH
+   2.1.4

lib/retriable.rb

@@ -49,7 +49,7 @@ def retriable(opts = {})
         base_interval:  base_interval,
         multiplier:     multiplier,
         max_interval:   max_interval,
-        rand_factor:    rand_factor
+        rand_factor:    rand_factor,
       ).intervals
     end
 
@@ -59,7 +59,7 @@ def retriable(opts = {})
       begin
         return Timeout.timeout(timeout) { return yield(try) } if timeout
         return yield(try)
-      rescue *[*exception_list] => exception
+      rescue *exception_list => exception
         if on.is_a?(Hash)
           raise unless exception_list.any? do |e|
             exception.is_a?(e) && ([*on[e]].empty? || [*on[e]].any? { |pattern| exception.message =~ pattern })

lib/retriable/config.rb

@@ -2,15 +2,15 @@
 
 module Retriable
   class Config
-    ATTRIBUTES = (ExponentialBackoff::ATTRIBUTES + [
-      :sleep_disabled,
-      :max_elapsed_time,
-      :intervals,
-      :timeout,
-      :on,
-      :on_retry,
-      :contexts,
-    ]).freeze
+    ATTRIBUTES = (ExponentialBackoff::ATTRIBUTES + %i[
+sleep_disabled
+max_elapsed_time
+intervals
+timeout
+on
+on_retry
+contexts
+]).freeze
 
     attr_accessor(*ATTRIBUTES)
 

lib/retriable/exponential_backoff.rb

@@ -1,12 +1,12 @@
 module Retriable
   class ExponentialBackoff
-    ATTRIBUTES = [
-      :tries,
-      :base_interval,
-      :multiplier,
-      :max_interval,
-      :rand_factor,
-    ].freeze
+    ATTRIBUTES = %i[
+tries
+base_interval
+multiplier
+max_interval
+rand_factor
+].freeze
 
     attr_accessor(*ATTRIBUTES)
 

retriable.gemspec

@@ -1,4 +1,4 @@
-# coding: utf-8
+
 lib = File.expand_path("../lib", __FILE__)
 $LOAD_PATH.unshift(lib) unless $LOAD_PATH.include?(lib)
 require "retriable/version"

spec/exponential_backoff_spec.rb

@@ -29,7 +29,7 @@
       4.350816718580626,
       5.339852157217869,
       11.889873261212443,
-      18.756037881636484,
+      18.756037881636484
     ])
   end
 
@@ -41,15 +41,15 @@
     expect(described_class.new(base_interval: 1).intervals).to eq([
       1.0488135024422882,
       1.8227840477522461,
-      2.4812175837998227,
+      2.4812175837998227
     ])
   end
 
   it "generates intervals with a defined multiplier" do
     expect(described_class.new(multiplier: 1).intervals).to eq([
       0.5244067512211441,
       0.607594682584082,
-      0.5513816852888495,
+      0.5513816852888495
     ])
   end
 
@@ -61,7 +61,7 @@
     expect(described_class.new(rand_factor: 0.2).intervals).to eq([
       0.5097627004884576,
       0.8145568095504492,
-      1.1712435167599646,
+      1.1712435167599646
     ])
   end