Added windowResized wiring #13
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes the final part of issue mveteanu#1 using SceneManager's newer, DRYer event handling. I don't believe SceneManager objects ever had a windowResized method, but if they had, the following code may be added at the end of the SceneManager constructor function: // Legacy method... preserved for maintaining compatibility this.windowResized = function() { this.handleEvent("windowResized"); }
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes the final part of issue #1 using SceneManager's newer, DRYer event handling.
I don't believe SceneManager objects ever had a
windowResizedmethod, but if they had, the following code may be added at the end of the SceneManager constructor function:// Legacy method... preserved for maintaining compatibility this.windowResized = function() { this.handleEvent("windowResized"); }