Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bugfixes: #16

Closed
wants to merge 2 commits into from
Closed

Bugfixes: #16

wants to merge 2 commits into from

Conversation

rppgorecki
Copy link

  1. InputFilter is created twice #15 (input filter created twice)
  2. $inputFilter->getInvalidInput() can return instance of InputFilterInterface, which doesn't implement getName()

rafal.gorecki added 2 commits November 7, 2019 12:43
Bugfixes:
32c41f5 
 1. mvlabs#15
 2. $inputFilter->getInvalidInput() can return instance of InputFilterInterface, which doesn't implement getName()
+ tests refactored
11d4498
@rppgorecki
Copy link
Author

rppgorecki commented Nov 7, 2019 •
edited
Loading

@drigani, @slaff please review - I have also refactored one unrelated test, so that checks can pass.

@rppgorecki
Copy link
Author

Looks like to is dead.

@rppgorecki rppgorecki closed this Mar 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@rppgorecki