Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Patch 1 #247

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

Patch 1 #247

wants to merge 4 commits into from

Conversation

jarnos
Copy link
Contributor

@jarnos jarnos commented Jan 22, 2020

No description provided.

Copy link
Collaborator

@rbalint rbalint left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, I added some minor rephrasing suggestions.

README.md Outdated
@@ -213,6 +213,11 @@ Supported Options Reference

NOTE that "never" is achieved by not setting any `Unattended-Upgrade::Mail`

* `Unattended-Upgrade::Remove-Unused-Kernel-Packages` - boolean (default:True)

Remove excessive unused kernel-related packages before upgrading so that
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!
The phrasing "... to avoid filling /boot or the root file system." may be even better.

README.md Outdated
@@ -224,7 +224,8 @@ Supported Options Reference

* `Unattended-Upgrade::Remove-New-Unused-Dependencies` - boolean (default:True)

Remove any new unused dependencies after the upgrade has finished.
Remove any new unused dependencies after the upgrade has finished. That is
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the original sentence can also benefit from rephrasing, like: "Remove packages which became unused during the upgrade".

@@ -213,6 +213,11 @@ Supported Options Reference

NOTE that "never" is achieved by not setting any `Unattended-Upgrade::Mail`

* `Unattended-Upgrade::Remove-Unused-Kernel-Packages` - boolean (default:True)

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please remove extra space.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Where?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Line 217

@rbalint
Copy link
Collaborator

rbalint commented Feb 25, 2020

Please squash the commits. This is four commits for changing 7 lines.

@jarnos
Copy link
Contributor Author

jarnos commented Feb 25, 2020

Please squash the commits. This is four commits for changing 7 lines.

I think end users do not mind. Besides, I do not know how to play squash on github.com.

@jarnos
Copy link
Contributor Author

jarnos commented Sep 5, 2021

Doesn't someone actually get paid for maintaining unattended-upgrades? I have provided patch that fixes the issues already...

@rbalint
Copy link
Collaborator

rbalint commented Sep 5, 2021

Doesn't someone actually get paid for maintaining unattended-upgrades? I have provided patch that fixes the issues already...

The patches were not accepted because the git history is not clean enough for a merge and I hoped that it would be cleaned up. The status of the PR reflects that as well. For the record I'm not a paid contributor at the moment.

@jarnos
Copy link
Contributor Author

jarnos commented Sep 5, 2021

I do not have an issue with the git history. If you have, please do something about it. If adding patches in https://github.com/ is supported it should be possible to do that dam squashing there, too, right? Too bad, if developers can not alter git history to their liking. Can't you just accept history you have caused? I have more important things to do.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants