-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
added docker example #42
Open
JohnRudolfLewis
wants to merge
4
commits into
mvukov:main
Choose a base branch
from
JohnRudolfLewis:docker-example
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JohnRudolfLewis
force-pushed
the
docker-example
branch
from
August 1, 2024 19:29
bb08eb6
to
58965a9
Compare
hofbi
reviewed
Sep 10, 2024
hofbi
reviewed
Sep 10, 2024
# to run the roslaunch command. | ||
oci_image( | ||
name = "chatter_oci_image", | ||
base = "@com_github_mvukov_rules_ros_base_image", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Suggested change
base = "@com_github_mvukov_rules_ros_base_image", | |
base = "@rules_ros_base_image", |
Co-authored-by: Markus Hofbauer <[email protected]>
Co-authored-by: Markus Hofbauer <[email protected]>
hofbi
reviewed
Sep 10, 2024
Comment on lines
+16
to
+27
bazel_dep(name = "rules_oci", version = "2.0.0") | ||
|
||
oci = use_extension("@rules_oci//oci:extensions.bzl", "oci") | ||
oci.pull( | ||
name = "rules_ros_base_image", | ||
image = "python:3.10-bookworm", | ||
digest = "sha256:428430918ab72109921ef55d5f8bdd3a02a90734fd79ee920146cf385a13c110", | ||
platforms = ["linux/amd64"], | ||
) | ||
use_repo(oci, "rules_ros_base_image", "rules_ros_base_image_linux_amd64") | ||
|
||
bazel_dep(name = "rules_pkg", version = "1.0.1") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
With the refactorings made in #43, we might want to move this into examples/MODULE.bazel
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
added example of packing up in to a docker container using rules_oci and rules_pkg
closes GH-10