Prevent crash in SequelizeStore.set and add test

mweibel · Mar 5, 2018 · f5b1c6c · f5b1c6c
1 parent 1eafad8
commit f5b1c6c
Show file tree

Hide file tree

Showing 2 changed files with 16 additions and 1 deletion.
diff --git a/lib/connect-session-sequelize.js b/lib/connect-session-sequelize.js
@@ -87,7 +87,7 @@ module.exports = function SequelizeSessionInit (Store) {
       defaults = this.options.extendDefaultFields(defaults, data)
     }
 
-    return this.sessionModel.findCreateFind({where: {'sid': sid}, defaults: defaults})
+    return this.sessionModel.findCreateFind({where: {'sid': sid}, defaults: defaults, raw: false})
     .spread(function sessionCreated (session) {
       var changed = false
       Object.keys(defaults).forEach(function (key) {

diff --git a/test/test.js b/test/test.js
@@ -89,6 +89,21 @@ describe('#set()', function () {
       assert.ok(session.expires instanceof Date, '.expires is not a date')
       assert.ok(session.expires > new Date(), '.expires is not in the future')
 
+      store.destroy(sessionId, function (err) {
+        assert.ok(!err, '#destroy() got an error')
+        done()
+      })
+    })
+  })
+  it('should have model instance methods', function (done) {
+    store.set(sessionId, sessionData, function (err, session) {
+      assert.ok(!err, '#set() got an error')
+      assert.ok(session, '#set() is not ok')
+
+      assert.ok(session.dataValues)
+      assert.ok(session.update)
+      assert.ok(session.save)
+
       store.destroy(sessionId, function (err) {
         assert.ok(!err, '#destroy() got an error')
         done()