Update email.py #463
Open
Update email.py #463
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added check for null lastUpdated to prevent crashes
fabiand93
approved these changes
Oct 23, 2023
4383
reviewed
Nov 6, 2023
| if target.sourceIds[container].lastUpdated: | ||
| print(f"Last profile edit : {target.sourceIds[container].lastUpdated.strftime('%Y/%m/%d %H:%M:%S (UTC)')}\n") | ||
| else: | ||
| gb.rc.print(f"Last profile edit : [italic]Not found.[/italic]\n") |
There was a problem hiding this comment.
Why using gb.rc (the rich console) in the else section and not in the if section?
I'd suggest to use one or the other in both sections.
There was a problem hiding this comment.
Well, I see the rich console documentation and the markup langage, so I suppose you used it to display in italic https://rich.readthedocs.io/en/stable/markup.html?highlight=italic#console-markup
Ignore my previous comment, your code LGTM
4383
approved these changes
Nov 6, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
added check for null lastUpdated to prevent crashes