Keep fromToken when switching swap option #234
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
dospore
suggested changes
Nov 29, 2022
Comment on lines
-1647
to
-1648
| setFromValue(""); | ||
| setToValue(""); |
There was a problem hiding this comment.
surely these have to remain the same if there arent any other changes?
There was a problem hiding this comment.
These two lines clear the value - Kurt requested that the value be retained across swap options, so by removing these the value stays the same
dospore
reviewed
Nov 29, 2022
dospore
reviewed
Nov 30, 2022
Comment on lines
+1649
to
+1650
| const updatedTokenSelection = JSON.parse(JSON.stringify(tokenSelection)); | ||
| updatedTokenSelection[opt].from = prevTokenAddress; |
There was a problem hiding this comment.
do we need to stringify then parse? could we just do { ...tokenSelection } if you wanted to shallow clone?
There was a problem hiding this comment.
yes we do, as the value is stored not only in state but in localStorage
dospore
approved these changes
Nov 30, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.