Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

remove fluent assertions #53

Merged
merged 1 commit into from
Jan 14, 2025
Merged

remove fluent assertions #53

merged 1 commit into from
Jan 14, 2025

Conversation

BenjaminAbt
Copy link
Member

@BenjaminAbt BenjaminAbt self-assigned this Jan 14, 2025
@BenjaminAbt BenjaminAbt requested a review from gfoidl January 14, 2025 13:53
gfoidl
gfoidl approved these changes Jan 14, 2025
View reviewed changes
Copy link
Contributor

@gfoidl gfoidl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unnecessary changes in the csprojs. Otherwise LGTM.

...serAgentParser.AspNetCore.UnitTests/MyCSharp.HttpUserAgentParser.AspNetCore.UnitTests.csproj
@@ -4,6 +4,10 @@
<OutputType>Exe</OutputType>
</PropertyGroup>

<ItemGroup>
<PackageReference Include="Microsoft.Extensions.DependencyInjection" />
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why this change?

Copy link
Member Author

@BenjaminAbt BenjaminAbt Jan 14, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I will transfer the Common Definitions like Roslyn etc into the Build Props... then I have to separate them here anyway.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, OK. But a separate PR for this would be welcomed 😉 That change is unrelated to "remove fluent assertions".

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, thats the plan

...rAgentParser.MemoryCache.UnitTests/MyCSharp.HttpUserAgentParser.MemoryCache.UnitTests.csproj
Comment on lines +8 to +9
<PackageReference Include="Microsoft.Extensions.Caching.Memory" />
<PackageReference Include="Microsoft.Extensions.DependencyInjection" />
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Undo this change and move it back to where it was.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same reason like above

tests/MyCSharp.HttpUserAgentParser.UnitTests/MyCSharp.HttpUserAgentParser.UnitTests.csproj
Comment on lines 8 to +9
<PackageReference Include="Microsoft.Extensions.DependencyInjection" />
</ItemGroup>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same here.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

same too :-)

@BenjaminAbt BenjaminAbt merged commit e29d24e into main Jan 14, 2025
2 checks passed
@BenjaminAbt BenjaminAbt deleted the feature/remove-fluent-assertions branch January 14, 2025 17:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gfoidl gfoidl gfoidl approved these changes

Assignees

@BenjaminAbt BenjaminAbt

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Remove Fluent Assertions
2 participants
@BenjaminAbt @gfoidl