Redeliver holding pen emails if there's a single guess #2500
Annotations
7 warnings
app/mailers/request_mailer.rb#L212
[rubocop] reported by reviewdog 🐶
[Correctable] Layout/EmptyLines: Extra blank line detected. (https://rubystyle.guide#two-or-more-empty-lines)
Raw Output:
app/mailers/request_mailer.rb:212:1: C: [Correctable] Layout/EmptyLines: Extra blank line detected. (https://rubystyle.guide#two-or-more-empty-lines)
|
app/mailers/request_mailer.rb#L213
[rubocop] reported by reviewdog 🐶
[Correctable] Layout/EmptyLineBetweenDefs: Expected 1 empty line between method definitions; found 2. (https://rubystyle.guide#empty-lines-between-methods)
Raw Output:
app/mailers/request_mailer.rb:213:3: C: [Correctable] Layout/EmptyLineBetweenDefs: Expected 1 empty line between method definitions; found 2. (https://rubystyle.guide#empty-lines-between-methods)
def guess_email_request_address(email)
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
app/mailers/request_mailer.rb#L258
[rubocop] reported by reviewdog 🐶
[Correctable] Layout/AssignmentIndentation: Indent the first line of the right-hand-side of a multi-line assignment.
Raw Output:
app/mailers/request_mailer.rb:258:5: C: [Correctable] Layout/AssignmentIndentation: Indent the first line of the right-hand-side of a multi-line assignment.
_("Could not identify the request from the email address")
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
app/mailers/request_mailer.rb#L287
[rubocop] reported by reviewdog 🐶
[Correctable] Style/TrailingCommaInArguments: Avoid comma after the last parameter of a method call. (https://rubystyle.guide#no-trailing-params-comma)
Raw Output:
app/mailers/request_mailer.rb:287:44: C: [Correctable] Style/TrailingCommaInArguments: Avoid comma after the last parameter of a method call. (https://rubystyle.guide#no-trailing-params-comma)
destination_request: info_request,
^
|
spec/mailers/request_mailer_spec.rb#L5
[rubocop] reported by reviewdog 🐶
[Correctable] Style/CommentAnnotation: Annotation keywords like TODO should be all upper case, followed by a colon, and a space, then a note describing the problem. (https://rubystyle.guide#annotate-keywords)
Raw Output:
spec/mailers/request_mailer_spec.rb:5:5: C: [Correctable] Style/CommentAnnotation: Annotation keywords like TODO should be all upper case, followed by a colon, and a space, then a note describing the problem. (https://rubystyle.guide#annotate-keywords)
# TODO add tests for guess_email_request_address
^^^^^
|
spec/models/guess_spec.rb#L11
[rubocop] reported by reviewdog 🐶
[Correctable] Layout/ExtraSpacing: Unnecessary spacing detected.
Raw Output:
spec/models/guess_spec.rb:11:34: C: [Correctable] Layout/ExtraSpacing: Unnecessary spacing detected.
it 'returns an id_score of 1' do
^
|
The following actions uses node12 which is deprecated and will be forced to run on node16: actions/checkout@v2. For more info: https://github.blog/changelog/2023-06-13-github-actions-all-actions-will-run-on-node16-instead-of-node12-by-default/
|
The logs for this run have expired and are no longer available.
Loading