Skip to content

Add ability to ask external caches to invalidate. #2541

Add ability to ask external caches to invalidate.

Add ability to ask external caches to invalidate. #2541

Triggered via pull request September 8, 2023 08:21
Status Failure
Total duration 1m 11s
Artifacts

rubocop.yml

on: pull_request
Fit to window
Zoom out
Zoom in

Annotations

2 errors and 10 warnings
build
reviewdog: Too many results (annotations) in diff. You may miss some annotations due to GitHub limitation for annotation created by logging command. Please check GitHub Actions log console to see all results. Limitation: - 10 warning annotations and 10 error annotations per step - 50 annotations per job (sum of annotations from all the steps) - 50 annotations per run (separate from the job annotations, these annotations aren't created by users) Source: https://github.community/t5/GitHub-Actions/Maximum-number-of-annotations-that-can-be-created-using-GitHub/m-p/39085
build
Process completed with exit code 1.
build: app/jobs/notify_cache_job.rb#L20
[rubocop] reported by reviewdog 🐶 Style/Documentation: Missing top-level documentation comment for class NotifyCacheJob. Raw Output: app/jobs/notify_cache_job.rb:20:1: C: Style/Documentation: Missing top-level documentation comment for class NotifyCacheJob. class NotifyCacheJob < ApplicationJob ^^^^^^^^^^^^^^^^^^^^
build: app/jobs/notify_cache_job.rb#L23
[rubocop] reported by reviewdog 🐶 [Correctable] Lint/UnusedMethodArgument: Unused method argument - method. If it's necessary, use _ or _method as an argument name to indicate that it won't be used. If it's unnecessary, remove it. (https://rubystyle.guide#underscore-unused-vars) Raw Output: app/jobs/notify_cache_job.rb:23:23: W: [Correctable] Lint/UnusedMethodArgument: Unused method argument - method. If it's necessary, use _ or _method as an argument name to indicate that it won't be used. If it's unnecessary, remove it. (https://rubystyle.guide#underscore-unused-vars) def perform(object, method = nil) ^^^^^^
build: app/jobs/notify_cache_job.rb#L39
[rubocop] reported by reviewdog 🐶 Layout/LineLength: Line is too long. [95/80] (https://rubystyle.guide#max-line-length) Raw Output: app/jobs/notify_cache_job.rb:39:81: C: Layout/LineLength: Line is too long. [95/80] (https://rubystyle.guide#max-line-length) Rails.logger.warn("PURGE: Unable to purge URL #{url} at #{host}: status #{result}") ^^^^^^^^^^^^^^^
build: app/models/comment.rb#L215
[rubocop] reported by reviewdog 🐶 [Correctable] Style/TrailingCommaInArrayLiteral: Avoid comma after the last item of an array. (https://rubystyle.guide#no-trailing-array-commas) Raw Output: app/models/comment.rb:215:51: C: [Correctable] Style/TrailingCommaInArrayLiteral: Avoid comma after the last item of an array. (https://rubystyle.guide#no-trailing-array-commas) show_user_wall_path(url_name: user.url_name), ^
build: app/models/foi_attachment.rb#L329
[rubocop] reported by reviewdog 🐶 [Correctable] Style/TrailingCommaInArrayLiteral: Avoid comma after the last item of an array. (https://rubystyle.guide#no-trailing-array-commas) Raw Output: app/models/foi_attachment.rb:329:50: C: [Correctable] Style/TrailingCommaInArrayLiteral: Avoid comma after the last item of an array. (https://rubystyle.guide#no-trailing-array-commas) request_path(incoming_message.info_request), ^
build: app/models/info_request.rb#L1167
[rubocop] reported by reviewdog 🐶 Lint/Syntax: unexpected token tCOMMA Raw Output: app/models/info_request.rb:1167:28: F: Lint/Syntax: unexpected token tCOMMA (Using Ruby 3.0 parser; configure using TargetRubyVersion parameter, under AllCops) if type in ('comment', 'edit_comment', 'hide_comment') ^
build: app/models/info_request.rb#L1924
[rubocop] reported by reviewdog 🐶 Lint/Syntax: unexpected token tCOMMA Raw Output: app/models/info_request.rb:1924:51: F: Lint/Syntax: unexpected token tCOMMA (Using Ruby 3.0 parser; configure using TargetRubyVersion parameter, under AllCops) do_track_path({ track_type='request_updates', info_request=self }, feed='feed'), ^
build: app/models/info_request.rb#L1924
[rubocop] reported by reviewdog 🐶 Lint/Syntax: unexpected token tRCURLY Raw Output: app/models/info_request.rb:1924:71: F: Lint/Syntax: unexpected token tRCURLY (Using Ruby 3.0 parser; configure using TargetRubyVersion parameter, under AllCops) do_track_path({ track_type='request_updates', info_request=self }, feed='feed'), ^
build: app/models/info_request.rb#L1924
[rubocop] reported by reviewdog 🐶 Lint/Syntax: unexpected token tRPAREN Raw Output: app/models/info_request.rb:1924:85: F: Lint/Syntax: unexpected token tRPAREN (Using Ruby 3.0 parser; configure using TargetRubyVersion parameter, under AllCops) do_track_path({ track_type='request_updates', info_request=self }, feed='feed'), ^
build: app/models/info_request.rb#L1926
[rubocop] reported by reviewdog 🐶 Lint/Syntax: unexpected token tCOMMA Raw Output: app/models/info_request.rb:1926:55: F: Lint/Syntax: unexpected token tCOMMA (Using Ruby 3.0 parser; configure using TargetRubyVersion parameter, under AllCops) do_track_path({ track_type='public_body_updates', public_body=public_body }, feed='feed'), ^