Skip to content

Commit

Permalink
Add colon after request summary intro
Browse files Browse the repository at this point in the history
Apple Mail (and potentially others) renders the next line immediately
after this line, so it reads as a continuation which gets confusing:

    > Here's your daily request summary from WhatDoTheyKnow Production,
    > and supply of foo…

After this change we'll have:

    > Here's your daily request summary from WhatDoTheyKnow: Production,
    > and supply of foo…
  • Loading branch information
garethrees committed Sep 11, 2023
1 parent 9c2d9b6 commit 67e56cd
Show file tree
Hide file tree
Showing 3 changed files with 3 additions and 3 deletions.
2 changes: 1 addition & 1 deletion app/views/notification_mailer/daily_summary.text.erb
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
<%= _("Here's your daily request summary from {{site_name}}",
<%= _("Here's your daily request summary from {{site_name}}:",
site_name: site_name.html_safe) %>
<% @grouped_notifications.each do |request, notifications| %>
Expand Down
2 changes: 1 addition & 1 deletion spec/fixtures/files/notification_mailer/daily-summary.txt
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
Here's your daily request summary from Alaveteli
Here's your daily request summary from Alaveteli:

The cost of paperclips
----------------------
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -16,6 +16,6 @@
render
expect(response).to match("the l'Information team")
expect(response).
to match("Here's your daily request summary from l'Information")
to match("Here's your daily request summary from l'Information:")
end
end

0 comments on commit 67e56cd

Please sign in to comment.