Add "campaigning" Citation#type

We're missing this from our three main Pro audiences – journalists, campaigners and researchers.
mysociety · Mar 11, 2024 · 7af5fff · 7af5fff
1 parent 84cf979
commit 7af5fff
Show file tree

Hide file tree

Showing 5 changed files with 11 additions and 3 deletions.
diff --git a/app/helpers/admin/citations_helper.rb b/app/helpers/admin/citations_helper.rb
@@ -2,6 +2,7 @@
 module Admin::CitationsHelper
   ICONS = {
     journalism: '🗞️',
+    campaigning: '📣',
     academic: '🎓',
     other: '🌐'
   }.with_indifferent_access.freeze

diff --git a/app/models/citation.rb b/app/models/citation.rb
@@ -29,7 +29,7 @@ class Citation < ApplicationRecord
                                    message: _('Source URL is too long') },
                          format: { with: /\Ahttps?:\/\/.*\z/,
                                    message: _('Please enter a Source URL') }
-  validates :type, inclusion: { in: %w(journalism academic other),
+  validates :type, inclusion: { in: %w(journalism academic campaigning other),
                                 message: _('Please select a type') }
 
   scope :newest, ->(limit = 1) do

diff --git a/app/views/citations/new.html.erb b/app/views/citations/new.html.erb
@@ -28,6 +28,11 @@
       <%= _('Journalism') %>
     </label>
 
+    <label for="citation_type_campaigning" class="form_label">
+      <%= f.radio_button :type, 'campaigning' %>
+      <%= _('Campaigning') %>
+    </label>
+
     <label for="citation_type_academic" class="form_label">
       <%= f.radio_button :type, 'academic' %>
       <%= _('Academic') %>

diff --git a/doc/CHANGES.md b/doc/CHANGES.md
@@ -2,8 +2,8 @@
 
 ## Highlighted Features
 
-* Broaden citation type classifications to cover wider thematic areas (Gareth
-  Rees)
+* Broaden citation type classifications to cover wider thematic areas and add
+  "campaigning" type (Gareth Rees)
 * Reduce amount of storage related background jobs (Graeme Porteous)
 * Add automatic parsing of emails contain Excel spreadsheets (Graeme Porteous)
 * Improve rendering of admin hidden request prominence and explanations (Graeme

diff --git a/spec/models/citation_spec.rb b/spec/models/citation_spec.rb
@@ -201,6 +201,8 @@ def setup_for_x_scope_data
       is_expected.not_to be_valid
       citation.type = 'journalism'
       is_expected.to be_valid
+      citation.type = 'campaigning'
+      is_expected.to be_valid
       citation.type = 'academic'
       is_expected.to be_valid
       citation.type = 'other'