fixup! Fix track alerts, add user's locale

mysociety · Jan 12, 2024 · c34265b · c34265b
1 parent c0aba99
commit c34265b
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 2 deletions.
diff --git a/app/controllers/application_controller.rb b/app/controllers/application_controller.rb
@@ -76,6 +76,7 @@ def set_gettext_locale
 
     locale = AlaveteliLocalization.set_session_locale(
       params[:locale],
+      current_user&.locale, # FIXME: Do we really want to use the user locale, or prioritise the session?
       session[:locale],
       cookies[:locale],
       browser_locale,

diff --git a/spec/integration/track_alerts_spec.rb b/spec/integration/track_alerts_spec.rb
@@ -21,7 +21,7 @@
     other_user = FactoryBot.create(:user)
     other_user_session = login(other_user)
     using_session(other_user_session) do
-      visit "en/annotate/request/#{info_request.url_title}"
+      visit "annotate/request/#{info_request.url_title}"
       fill_in "comment[body]", with: 'test comment'
       click_button 'Preview your annotation'
       click_button 'Post annotation'
@@ -67,7 +67,7 @@
                                      locale: 'es')
     user_session = login(user)
     using_session(user_session) do
-      visit "es/request/#{info_request.url_title}/track"
+      visit "request/#{info_request.url_title}/track"
     end
 
     other_user = FactoryBot.create(:user, locale: 'en')