Skip to content

Commit

Permalink
Update GitHub workflow events
Browse files Browse the repository at this point in the history
Be explicit which event types we want to run on. This removed the
default `reopened` event type. If a PR gets reopened we should be
rebasing it rather than testing against old code.
  • Loading branch information
gbp committed Oct 26, 2023
1 parent b4599f2 commit e9e9de6
Show file tree
Hide file tree
Showing 2 changed files with 8 additions and 1 deletion.
3 changes: 3 additions & 0 deletions .github/workflows/ci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,9 @@ on:
push:
branches: [master, develop]
pull_request:
types:
- opened
- synchronize

concurrency:
group: ${{ github.workflow }}-${{ github.head_ref || github.run_id }}
Expand Down
6 changes: 5 additions & 1 deletion .github/workflows/rubocop.yml
Original file line number Diff line number Diff line change
@@ -1,6 +1,10 @@
name: RuboCop

on: [pull_request]
on:
pull_request:
types:
- opened
- synchronize

permissions:
contents: read
Expand Down

0 comments on commit e9e9de6

Please sign in to comment.