[#7855] Attachment masking fixes #7856
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We're going to add additional contexts so refactor some specs tto add an initial context.
We might have attachments in the database with the incorrect hexdigest. If so we won't be able to find the original attachment body. This commit adds a method which accounts for 2 scenarios which might cause the hexdigest to change. 1. different line endings, 2 leading zeros on dates Both of these changes have been caused by upstream changes to the mail gem we use to parse the emails but this hasn't been apparent until recently.
Now attempt to find the attachment by calculating the hexdigest based on a number of possible difference that have been observed. See previous commit. Fixes #7855
Ensure we don't get stuck in the loop when masking jobs are already queued.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Relevant issue(s)
Fixes #7855
What does this do?
Work around some of the common cases why the original attachment body can't be found.
Why was this needed?
Seemingly randomly broken pages and failed background jobs.
Implementation notes
Screenshots
Notes to reviewer