Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[#7886] trailing white space attachment processing #7887

Merged
merged 3 commits into from
Sep 4, 2023
Merged

[#7886] trailing white space attachment processing #7887

merged 3 commits into from
Sep 4, 2023

Commits on Sep 4, 2023

  1. Extract calculation of attachment hexdigest 

    Same operations are being performed three times. Extract out into a
helper function in order to simplify the code.
    @gbp
    gbp committed Sep 4, 2023
    Configuration menu
    Copy the full SHA
    2a903e2 View commit details
    Browse the repository at this point in the history

  2. Extract common attachment hexdigest 

    We don't need to calculated the digest for the body passed as an
argument more than once.
    @gbp
    gbp committed Sep 4, 2023
    Configuration menu
    Copy the full SHA
    5c4d3f0 View commit details
    Browse the repository at this point in the history

  3. Fix white space attachment processing 

    Some previously extracted attachment appear to have extra trailing
white space, this commits strips this in order identify the original
attachment body.

Fixes #7886
    @gbp
    gbp committed Sep 4, 2023
    Configuration menu
    Copy the full SHA
    55d211c View commit details
    Browse the repository at this point in the history