[#7189] Details page showing keys metadata #7892
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dracos
force-pushed
the
details-page-showing-keys-metadata
branch
from
dca17ac
to
d29dfe8
Compare
dracos
force-pushed
the
details-page-showing-keys-metadata
branch
from
d29dfe8
to
0f3aae0
Compare
gbp
changed the title
garethrees
reviewed
Oct 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #7189
Two suggestions, could take one or both - the first changes "edit" to "edit metadata" on the details page, which I think makes it clearer (especially when there's no edit_incoming or edit_outgoing etc) that an edit of a request is editing its metadata rather than text of messages within the request.
And then as suggested on the ticket adds a column to show the keys that have changed as part of an event.