Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minor wording changes for new authorities email #7936

Closed
wants to merge 4 commits into from

Conversation

confirmordeny
Copy link
Collaborator

Relevant issue(s)

This change will reduce admin time editing the default outgoing message when accepting a request to add a new authority.

What does this do?

"Thanks" ---> "Thank you"
"Yours," ---> "Kind regards,"

Why was this needed?

See above.

Implementation notes

N/A

Screenshots

N/A

Notes to reviewer

See above.

"send" is clearer than "file". The term "file" could mean (a) submitting it to a public authority or (b) placing the request in a storage system.
I prefer "Thank you" to "Thanks" when I am writing to thank someone.

Also, when sending emails, we tend to use "Kind regards, " and not "Yours,".
revert to old wording
@gbp
Copy link
Member

gbp commented Oct 11, 2023

Going to bump this to WDTK theme as changing strings in core Alaveteli makes extra work for translators.

mysociety/whatdotheyknow-theme#1795

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
easier-admin Make issues easier to resolve
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants