Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Import changelog #7940

Merged
merged 4 commits into from
Oct 9, 2023
Merged

Import changelog #7940

merged 4 commits into from
Oct 9, 2023

Conversation

garethrees
Copy link
Member

@garethrees garethrees commented Oct 6, 2023

Make it easier for admins to read about new features that have been added to Alaveteli from within Alaveteli itself.

Screenshot 2023-10-06 at 16 29 01

Screenshot 2023-10-06 at 16 29 10

Duplicate heading.
Make it easier for admins to read about new features that have been
added to Alaveteli from within Alaveteli itself.
@garethrees garethrees marked this pull request as ready for review October 6, 2023 15:30
Copy link
Member

@gbp gbp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice. This could be useful. Any though given to making it clearer which version of Alaveteli is currently installed? Just rendering the changelog could make re-users think they have the latest features.

Make it more explicit what version of Alaveteli is installed, with a
link through to the debug page for further info.
@garethrees
Copy link
Member Author

Nice. This could be useful.

🎉

Any though given to making it clearer which version of Alaveteli is currently installed?

Could add a quick line like (which links to /admin/debug):

Screenshot 2023-10-06 at 16 40 45

Just rendering the changelog could make re-users think they have the latest features.

I was thinking that the changelog that gets rendered is only ever up to the installed version, which will have the version number as the first heading (e.g. if you have 0.41.0.0 installed, the first heading will be 0.41.0.0). Then when you click through to one of the GitHub links you'd see a newer number. Being explicit about the current version doesn't hurt though, so have pushed an extra commit (ce1db92).

@gbp
Copy link
Member

gbp commented Oct 6, 2023

I was thinking that the changelog that gets rendered is only ever up to the installed version, which will have the version number as the first heading (e.g. if you have 0.41.0.0 installed, the first heading will be 0.41.0.0)

Oh, of course, that makes sense!

@garethrees garethrees merged commit 5181993 into develop Oct 9, 2023
3 checks passed
@garethrees garethrees deleted the import-changelog branch October 9, 2023 14:24
@garethrees garethrees restored the import-changelog branch October 9, 2023 14:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants