[7787] Always use /request/ prefix #8142
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexander-griffen
force-pushed
the
7787-always-use-request-prefix
branch
2 times, most recently
from
6ab78cf
to
afc78ed
Compare
gbp
changed the title
gbp
force-pushed
the
7787-always-use-request-prefix
branch
from
ab5645b
to
66d97c0
Compare
gbp
force-pushed
the
7786-remove-locale-prefix-urls
branch
from
0ee6a01
to
11cbe40
Compare
This commit does the following: - Removes a redirect in the request controller to redirect embargoed requests for pro specific URL - Replaces Alaveteli Pro request URLs and routes with the standard route - Disables spec examples testing pro context redirection as these tests will need to be rewritten once the old routing is updated
This commit removes the Alaveteli Pro info request route and also sets up a redirect from this route to the standard request route.
This commit removes the redirect for public requests from the pro context as it no longer can be ran
We're not redirecting to the pro specific request route any more, instead update these tests to check when the pro livery is used or not.
gbp
force-pushed
the
7787-always-use-request-prefix
branch
from
66d97c0
to
74ed261
Compare
|
Merged in 923a21e |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Relevant issue(s)
Fixes #7787
What does this do?
This PR removes the Alaveteli Pro request path -
/alaveteli_pro/info_requests/:url_titleand ensures that the standard request path -/request/:url_titleis followed instead.Why was this needed?
Simplification of admin procedures.