[#7771 & #7809] Add styling and rich text notes #8153
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gbp
force-pushed
the
7809-add-actiontext-to-notes
branch
2 times, most recently
from
c27a1e6
to
3998b0b
Compare
garethrees
reviewed
Mar 11, 2024
gbp
force-pushed
the
7809-add-actiontext-to-notes
branch
from
3998b0b
to
5bd28cd
Compare
- Better separation of layout and styling - Made it easier to add different note style
This commit adds helpers to render notes either as text or sanitized HTML. This will allow us to easily update note rendering for rich text content by changing these helpers,
This commit allows admins to create notes with different colour styles. The default styles are just red, green, blue and yellow. Additional styles can be added via the site theme.
Unable to use ActiveRecord ordering as we're dealing with both concert and tagged notes.
Add JS/CSS to the admin layout only. To prevent deprecation warnings we set the following as this will be the default in Rails 7.1: `config.active_storage.replace_on_assign_to_many = true`
Use ActionText Trix editor to allow rich text notes. We render the rich text body when the note isn't in the original style. This commit also hides the image attachment button in the Trix editor as we will need to store the files correctly which won't work currently with the current ActiveStorage setup.
gbp
force-pushed
the
7809-add-actiontext-to-notes
branch
from
a244cb1
to
ddaff31
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Relevant issue(s)
Fixes #7771
Fixes #7809
What does this do?
Add styling and rich text notes
Why was this needed?
Enable easier styling of note content.
Implementation notes
Have added an "original" style which renders notes as they are currently. Eventually we might choose to migrate current notes on WDTK and remove this style.
Screenshots