Extract User::SpreadableAlerts #8155
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These methods don't interact with anything else inside User and all relate to some incidental behaviour so are ripe for extraction.
Same behaviour; more elegant.
gbp
approved these changes
Mar 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this do?
Extract a group of methods from
Userthat handle spreading alert times throughout the dayWhy was this needed?
Compartmentalise some incidental behaviour. 🧈
Implementation notes
Missing a spec for
spread_alert_times_across_day. This isn't actually called anywhere and I'm not sure it's been called manually for a very very long time, so could remove it.[skip changelog]