Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[#8190] Fix logout issues #8195

Merged
merged 2 commits into from
Apr 9, 2024
Merged

[#8190] Fix logout issues #8195

merged 2 commits into from
Apr 9, 2024

Commits on Apr 9, 2024

  1. Update setting gettext locale 

    Split the configuration of the i18n locale gems and storing the locale
in the user session into separate actions.

This will allow us to skip storing the session in controller actions
where this isn't desirable.
    @gbp
    gbp committed Apr 9, 2024
    Configuration menu
    Copy the full SHA
    e97ae72 View commit details
    Browse the repository at this point in the history

  2. Fix issues where users could be logged out 

    There is conflict when calling `render html: ...` which we do in
AttachmentController#show_as_html and updating the session which is
causing the session to be reset.

This change prevents the session from being updated in the before action
hook.

Fixes #8190
    @gbp
    gbp committed Apr 9, 2024
    Configuration menu
    Copy the full SHA
    9e78dd7 View commit details
    Browse the repository at this point in the history