Update admin tag routing constraints #8248
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Allow admin pages for tags with `.` or `/` to be loaded successfully. This means tags can be URLs which is currently a use case used on WDTK. It does mean we can't have member actions on the tags resource but as of now we don't have any. If ever we want an `edit` action we can adjust the constraint to allow this.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this do?
Update admin tag routing constraints
Why was this needed?
Allow admin pages for tags with
.or/to be loaded successfully. This means tags can be URLs which is currently a use case used on WDTK.It does mean we can't have member actions on the tags resource but as of now we don't have any. If ever we want an
editaction we can adjust the constraint to allow this.