Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[#8344] Fix rendering invoices view #8345

Merged
merged 4 commits into from
Aug 13, 2024
Merged

[#8344] Fix rendering invoices view #8345

merged 4 commits into from
Aug 13, 2024

Conversation

gbp
Copy link
Member

@gbp gbp commented Jul 29, 2024

Relevant issue(s)

Fixes #8344

What does this do?

Fix rendering invoices view

Why was this needed?

Exceptions when Pro/former-pro users attempted to view their Pro invoices. Happened when there were 100% discounted invoices resulting in no charges.

Return nil if there is no Stripe charge. This happens when the invoice
has been 100% discounted.
Return false if the invoice has been 100% discounted. This will prevent
the "View Receipt" link being rendered when there is no payment receipt.
@gbp gbp merged commit 2b321c6 into develop Aug 13, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[ERROR] Could not determine which URL to request: Stripe::Charge instance has invalid ID: nil
1 participant