Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stripe prices #8424

Open
wants to merge 4 commits into
base: stripe-prices-refactor
Choose a base branch
from
Open

Stripe prices #8424

wants to merge 4 commits into from

Conversation

gbp
Copy link
Member

@gbp gbp commented Oct 18, 2024

Relevant issue(s)

https://github.com/mysociety/whatdotheyknow-private/issues/328
Depends on #8405
Depends on #8407

What does this do?

Switches from Stripe Plans to Prices allowing us to change subscriptions and update Pro our pricing model.

@gbp gbp changed the base branch from develop to stripe-prices-refactor October 18, 2024 11:33
@gbp gbp marked this pull request as ready for review November 6, 2024 14:42
@gbp gbp requested a review from dracos November 6, 2024 14:42
@gbp
Copy link
Member Author

gbp commented Nov 6, 2024

@dracos it has been suggested that you might be the best places to review this. There are a lot of additional changes in the linked PRs which really someone should review but not sure if you've really got time to do that?

@dracos
Copy link
Member

dracos commented Nov 6, 2024

Sure, I can take a look at them all

Copy link
Member

@dracos dracos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, couple of queries is all :)

app/models/alaveteli_pro/price.rb Outdated Show resolved Hide resolved
spec/views/alaveteli_pro/plans/index.html.erb_spec.rb Outdated Show resolved Hide resolved
@gbp gbp force-pushed the stripe-prices-refactor branch 3 times, most recently from 7ada4b3 to 0994a53 Compare November 11, 2024 12:51
Using Prices provides more flexibility and will allow us to change the
which prices are used on both current and future subscriptions.
Run via:
`rails subscriptions:migrate_price OLD_PRICE=pro NEW_PRICE=price_123`
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants