Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added max-width to multi-select-button #5171

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

lucascumsille
Copy link
Contributor

Because of its usage(multi-select) this element can get quite long the more options are added. This PR replaces the max-width(100%) from GOVUK and changes to 12.5em

[Skip changelog]

Preview
Screenshot 2024-09-17 at 12 19 54

Screenshot 2024-09-17 at 12 19 31 Screenshot 2024-09-17 at 12 23 30

Copy link

codecov bot commented Sep 17, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 82.41%. Comparing base (5ee915d) to head (b252d94).

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #5171      +/-   ##
==========================================
+ Coverage   82.40%   82.41%   +0.01%     
==========================================
  Files         415      415              
  Lines       32855    32859       +4     
  Branches     5270     5270              
==========================================
+ Hits        27074    27081       +7     
+ Misses       4223     4220       -3     
  Partials     1558     1558              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Because of its usage this element can get quite long the more options are added. This PR replaces the max-width(100%) from GOVUK and changes to 12.5em
@dracos dracos force-pushed the multi-select-button-width branch from 2a82501 to b252d94 Compare December 19, 2024 13:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant