[Bexley] Ignore duplicate log entries from Whitespace #5320
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #5320 +/- ##
=======================================
Coverage 82.43% 82.44%
=======================================
Files 415 415
Lines 32900 32904 +4
Branches 5276 5277 +1
=======================================
+ Hits 27122 27128 +6
Misses 4219 4219
+ Partials 1559 1557 -2 ☔ View full report in Codecov by Sentry. |
davea
approved these changes
Jan 6, 2025
Sometimes Whitespace will return identical logs which only differ by a few seconds, but have different IDs. We want to ignore these as they don't give us any extra information and look confusing when displayed to the user.
mysociety-pusher
force-pushed
the
bexley-whitespace-ignore-duplicate-log-entries
branch
from
7de60c1 to
316359b
Compare
mysociety-pusher
temporarily deployed
to
github-pages
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sometimes Whitespace will return identical logs which only differ by a few seconds, but have different IDs. We want to ignore these as they don't give us any extra information and look confusing when displayed to the user.
For FD-4974