Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add UK-specific excluded calculated homepage domains #1789

Merged
merged 1 commit into from
Oct 19, 2023

Conversation

garethrees
Copy link
Member

@garethrees
Copy link
Member Author

Any more we want to catch? Don't need to be exhaustive at this point, but might have missed a few obvious ones.

@gbp
Copy link
Member

gbp commented Oct 19, 2023

@garethrees the specs are failing on this guessing that is because the core PR hasn't been merged. Attempting to run this locally and it doesn't seem to be working, am I missing something?

@gbp
Copy link
Member

gbp commented Oct 19, 2023

[1] pry(main)> PublicBody.excluded_calculated_home_page_domains
=> ["aol.com",
 "gmail.com",
 "googlemail.com",
 "gmx.com",
 "hotmail.com",
 "icloud.com",
 "live.com",
 "mac.com",
 "mail.com",
 "mail.ru",
 "me.com",
 "outlook.com",
 "protonmail.com",
 "qq.com",
 "yahoo.com",
 "yandex.com",
 "ymail.com",
 "zoho.com",
 ["aol.co.uk",
  "blueyonder.co.uk",
  "btconnect.com",
  "btinternet.com",
  "btopenworld.com",
  "hotmail.co.uk",
  "live.co.uk",
  "ntlworld.com",
  "sky.com",
  "talk21.com",
  "talktalk.net",
  "tiscali.co.uk",
  "virginmedia.com",
  "yahoo.co.uk"]]

@gbp gbp force-pushed the uk-excluded_calculated_home_page_domains branch from dd95099 to 9f91e1c Compare October 19, 2023 11:09
@gbp gbp merged commit 6356382 into master Oct 19, 2023
4 checks passed
@garethrees
Copy link
Member Author

Ah, woops!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants