Don't use tc shaper on Linux if userspace mode is active #5971
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Anton Litvinov <[email protected]>
Zensey
requested review from
soffokl,
Waldz,
tadaskay,
mdomasevicius,
Snawoot and
Guillembonet
as code owners
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #5971 +/- ##
==========================================
- Coverage 37.93% 37.84% -0.09%
==========================================
Files 371 371
Lines 20661 20661
==========================================
- Hits 7837 7820 -17
- Misses 12048 12060 +12
- Partials 776 781 +5 ☔ View full report in Codecov by Sentry. |
soffokl
approved these changes
Feb 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Userspace mode implies running node w/o sudo,
but use of tc shaper is useless for this mode and relies on sudo prompt
Symptom: no traffic is flowing