Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed componentWillReceiveProps warning #204

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

AureliaRoumesy
Copy link

Update
react-native-material-textfield version
react-native-material-buttons version

Fixed

Deprecation warnings for React component lifecycle methods

Issue #192

…tons to latest version and fix Deprecation warnings for React component lifecycle methods
@muhammadsr
Copy link

can we merge this?

@YahiaBadr
Copy link

Please merge the warnings are so annoying.
Hope this project didn't reach a dead end.

@yaron1m
Copy link

yaron1m commented Apr 3, 2020

Please merge this 🙏

@xvonabur
Copy link

xvonabur commented Apr 7, 2020

This PR changed default behaviour. Suppose I have separate values and labels for dropdown options like this:

{
  label: 'Zero cases',
  value: '0'
}

After I press dropdown, I see Zero cases text, but field changes to 0 after selecting this option. I would like to see Zero cases as selected value, not 0

EDIT:

@AureliaRoumesy, I've fixed it in my fork. Don't know why you need displayLabel. Ordinary labels work just fine for me.
Please, check my latest commit of my fork: xvonabur@55e70d0

@chriscom2019
Copy link

I'm using this component in one of my projects. How do apply changes to my project?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

9 participants