feat(core): Keep track of test case executions during test run (no-changelog) #12787
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
n8n-assistant
bot
added
core
Codecov ReportAttention: Patch coverage is 📢 Thoughts on this report? Let us know! |
tomi
previously approved these changes
Jan 29, 2025
packages/cli/src/databases/migrations/common/1736947513045-CreateTestCaseExecutionTable.ts
Show resolved
Hide resolved
packages/cli/src/databases/migrations/common/1736947513045-CreateTestCaseExecutionTable.ts
Show resolved
Hide resolved
packages/cli/src/evaluation.ee/test-runner/test-runner.service.ee.ts
Outdated
Show resolved
Hide resolved
packages/cli/src/evaluation.ee/test-runner/test-runner.service.ee.ts
Outdated
Show resolved
Hide resolved
|
|
n8n
|
||||||||||||||||||||||||||||
| Project |
n8n
|
| Branch Review |
ai-524-link-evaluation-executions-to-test-runs-test-cases
|
| Run status |
|
| Run duration | 04m 59s |
| Commit |
|
| Committer | Eugene Molodkin |
| View all properties for this run ↗︎ | |
| Test results | |
|---|---|
Failures
|
0
|
Flaky
|
3
|
Pending
|
5
|
Skipped
|
0
|
Passing
|
432
|
| View all changes introduced in this branch ↗︎ | |
…runs-test-cases # Conflicts: # packages/cli/src/evaluation.ee/test-runner/test-runner.service.ee.ts
tomi
approved these changes
Jan 31, 2025
Comment on lines
59
to
61
| trx?: EntityManager, | ||
| ) { | ||
| return await this.update( | ||
| trx = trx ?? this.manager; |
There was a problem hiding this comment.
This could also be
trx = this.manager
)
Same for the other repository methods here and in test-run.repository
|
✅ All Cypress E2E specs passed |
burivuhster
deleted the
ai-524-link-evaluation-executions-to-test-runs-test-cases
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR introduces a new entity "TestCaseExecution". It represents a specific past execution being "re-run" and evaluated during a specific Test Run.
The idea is to store the connection between Test Runs and related executions (past, new and evaluation) in a separate table, together with statuses, errors, individual metrics produced by the evaluation workflow. This will allow us to keep track of the details of each Test Run even after related executions will be pruned, and make data fetching more efficient and straightforward in general. Previously, we had to rely on a workaround with the
testRunIdproperty added to each evaluation execution's metadata.Related Linear tickets, Github issues, and Community forum posts
Review / Merge checklist
release/backport(if the PR is an urgent fix that needs to be backported)