Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(core): Handle max stalled count error better #12824

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

ivov
Copy link
Contributor

@ivov ivov commented Jan 24, 2025

Summary

The max stalled count error is not being wrapped correctly and could use with clearer phrasing.

Context: https://n8nio.slack.com/archives/C035KBDA917/p1737657316221569

To test:

  1. Clear all bull keys: docker exec -it n8n-redis redis-cli EVAL "redis.call('DEL', unpack(redis.call('KEYS', 'bull:*')))" 0
  2. Comment out this line and build: await this.recoveryService.recoverFromLogs(executionId, logMesssages ?? [])
  3. Start a main and two workers
  4. Activate a workflow with a webhook and an OOM debug helper, call the webhook
  5. Worker will pick up job and crash, other worker same, main surfaces clear max stalled count error

Capture 2025-01-24 at 10 08 21@2x

Related Linear tickets, Github issues, and Community forum posts

n/a

Review / Merge checklist

  • PR title and summary are descriptive. (conventions)
  • Docs updated or follow-up ticket created.
  • Tests included.
  • PR Labeled with release/backport (if the PR is an urgent fix that needs to be backported)

Copy link

codecov bot commented Jan 24, 2025

Codecov Report

Attention: Patch coverage is 25.00000% with 3 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
packages/cli/src/workflow-runner.ts 33.33% 2 Missing ⚠️
packages/cli/src/errors/max-stalled-count.error.ts 0.00% 1 Missing ⚠️

📢 Thoughts on this report? Let us know!

@n8n-assistant n8n-assistant bot added core Enhancement outside /nodes-base and /editor-ui n8n team Authored by the n8n team labels Jan 24, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
core Enhancement outside /nodes-base and /editor-ui n8n team Authored by the n8n team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant