Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(editor): Always keep at least one executing node indicator in the workflow #12829

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

alexgrozav
Copy link
Member

@alexgrozav alexgrozav commented Jan 24, 2025

Summary

Added a node execution queue that ensures there's always at least one node executing in the workflow until it finishes.

When emitting nodeExecuteBefore and nodeExecuteAfter socket events, the data serialization function is too slow when dealing with large amounts of data. This causes events to be delayed and we end up in a state where the previous node has finished and the new node event takes a while to start, therefore there's no node currently executing. This leads users to believe the workflow is stuck or finished.

Related Linear tickets, Github issues, and Community forum posts

https://linear.app/n8n/issue/CAT-324/bug-spinner-doesnt-show-up-on-executing-nodes

Review / Merge checklist

  • PR title and summary are descriptive. (conventions)
  • Docs updated or follow-up ticket created.
  • Tests included.
  • PR Labeled with release/backport (if the PR is an urgent fix that needs to be backported)

@alexgrozav alexgrozav self-assigned this Jan 24, 2025
@n8n-assistant n8n-assistant bot added n8n team Authored by the n8n team ui Enhancement in /editor-ui or /design-system labels Jan 24, 2025
Copy link

codecov bot commented Jan 24, 2025

Codecov Report

Attention: Patch coverage is 94.44444% with 1 line in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
packages/editor-ui/src/stores/workflows.store.ts 94.44% 1 Missing ⚠️

📢 Thoughts on this report? Let us know!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
n8n team Authored by the n8n team ui Enhancement in /editor-ui or /design-system
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant