feat(editor): Always keep at least one executing node indicator in the workflow #12829
+111
−1
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Added a node execution queue that ensures there's always at least one node executing in the workflow until it finishes.
When emitting
nodeExecuteBefore
andnodeExecuteAfter
socket events, the data serialization function is too slow when dealing with large amounts of data. This causes events to be delayed and we end up in a state where the previous node has finished and the new node event takes a while to start, therefore there's no node currently executing. This leads users to believe the workflow is stuck or finished.Related Linear tickets, Github issues, and Community forum posts
https://linear.app/n8n/issue/CAT-324/bug-spinner-doesnt-show-up-on-executing-nodes
Review / Merge checklist
release/backport
(if the PR is an urgent fix that needs to be backported)