Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(core): Display the last activated plan name when multiple are activated #12835

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

csuermann
Copy link
Contributor

When an n8n instance is activated with multiple main plan licenses, the Usage and Plan page currently displays the name of the first activated plan. (However, the instance still benefits from the combined features of all activated licenses.) This can be confusing for users, who expect the UI to reflect the name of the most recently activated plan. For example, a user upgrading from a "Registered Community" license to an "Enterprise License" would naturally expect the latter to be displayed in the UI.

This PR resolves the issue by ensuring the UI always displays the name of the most recently activated plan, aligning with user expectations.

@csuermann csuermann requested a review from Joffcom January 24, 2025 14:55
@n8n-assistant n8n-assistant bot added core Enhancement outside /nodes-base and /editor-ui n8n team Authored by the n8n team labels Jan 24, 2025
Copy link

codecov bot commented Jan 24, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

📢 Thoughts on this report? Let us know!

Copy link
Member

@Joffcom Joffcom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That looks like it does the job and the test seems to cover it 👍🏻

Copy link

cypress bot commented Jan 24, 2025

n8n    Run #8932

Run Properties:  status check passed Passed #8932  •  git commit a8ad64c5ff: 🌳 🖥️ browsers:node18.12.0-chrome107 🤖 csuermann 🗃️ e2e/*
Project n8n
Branch Review latest-main-plan
Run status status check passed Passed #8932
Run duration 04m 23s
Commit git commit a8ad64c5ff: 🌳 🖥️ browsers:node18.12.0-chrome107 🤖 csuermann 🗃️ e2e/*
Committer Cornelius Suermann
View all properties for this run ↗︎

Test results
Tests that failed  Failures 0
Tests that were flaky  Flaky 3
Tests that did not run due to a developer annotating a test with .skip  Pending 5
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 430
View all changes introduced in this branch ↗︎

Copy link
Contributor

✅ All Cypress E2E specs passed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
core Enhancement outside /nodes-base and /editor-ui n8n team Authored by the n8n team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants