Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(editor): Fix the path to which tree-sitter wasm files are copied to (no-changelog) #13389

Merged
merged 1 commit into from
Feb 25, 2025

Conversation

netroy
Copy link
Member

@netroy netroy commented Feb 20, 2025

Summary

Released versions of n8n-editor-ui are already somehow copying over these .wasm files to the dist folder instead of dist/public, which is making the curl-converter feature work as expected in released versions of the frontend.
However in dev setup, and in custom images, the .wasm files are in the wrong location, which breaks the curl import feature.

Review / Merge checklist

  • PR title and summary are descriptive. (conventions)
  • Docs updated or follow-up ticket created.
  • Tests included.
  • PR Labeled with release/backport (if the PR is an urgent fix that needs to be backported)

Copy link

codecov bot commented Feb 20, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

📢 Thoughts on this report? Let us know!

@n8n-assistant n8n-assistant bot added n8n team Authored by the n8n team ui Enhancement in /editor-ui or /design-system labels Feb 20, 2025
Copy link

cypress bot commented Feb 25, 2025

n8n    Run #9465

Run Properties:  status check passed Passed #9465  •  git commit 0f27198754: 🌳 🖥️ browsers:node18.12.0-chrome107 🤖 netroy 🗃️ e2e/*
Project n8n
Branch Review fix-tree-sitter-copy-path
Run status status check passed Passed #9465
Run duration 04m 38s
Commit git commit 0f27198754: 🌳 🖥️ browsers:node18.12.0-chrome107 🤖 netroy 🗃️ e2e/*
Committer कारतोफ्फेलस्क्रिप्ट™
View all properties for this run ↗︎

Test results
Tests that failed  Failures 0
Tests that were flaky  Flaky 0
Tests that did not run due to a developer annotating a test with .skip  Pending 5
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 437
View all changes introduced in this branch ↗︎

Copy link
Contributor

✅ All Cypress E2E specs passed

@netroy netroy merged commit 6706aa6 into master Feb 25, 2025
38 checks passed
@netroy netroy deleted the fix-tree-sitter-copy-path branch February 25, 2025 11:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
n8n team Authored by the n8n team ui Enhancement in /editor-ui or /design-system
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants