-
Notifications
You must be signed in to change notification settings - Fork 14.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(core): Make Tools Agent the default Agent type, deprecate other agent types #13459
base: master
Are you sure you want to change the base?
feat(core): Make Tools Agent the default Agent type, deprecate other agent types #13459
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅ 📢 Thoughts on this report? Let us know! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. I know e2e tests might fail, so approving to help you get an idea as well.
n8n
|
Project |
n8n
|
Branch Review |
ado-2779-feature-agent-node-get-rid-of-type-drop-down
|
Run status |
|
Run duration | 04m 44s |
Commit |
|
Committer | Jaakko Husso |
View all properties for this run ↗︎ |
Test results | |
---|---|
|
0
|
|
3
|
|
5
|
|
0
|
|
437
|
View all changes introduced in this branch ↗︎ |
✅ All Cypress E2E specs passed |
@@ -96,6 +96,13 @@ export const reActAgentAgentProperties: INodeProperties[] = [ | |||
rows: 6, | |||
}, | |||
}, | |||
{ | |||
displayName: 'Max Iterations', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
is this already used? testing on the test instance and it does not seem to have an effect?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
no, you're right. I suppose I had mistakenly assumed the logic where these options was read and passed to the executor was generic and applied to all of these, but it was only on some.
Now actually looking into this it appears that only new place where maxIterations
can be supported is ReActAgent
, as the other langchain executors used on these other node types (PlanAndExecuteAgent
, SqlAgent
) don't seem to support it.
I'm removing maxIterations
from PlanAndExecuteAgent
and SqlAgent
and properly passing it on ReActAgent
.
packages/@n8n/nodes-langchain/nodes/agents/Agent/agents/SqlAgent/description.ts
Outdated
Show resolved
Hide resolved
…QL agents, fix it on ReActAgent
Summary
Users have found the Agent type selection to be confusing, and in vast majority of the cases
Tools Agent
is the only recommended Agent type to use. To simplify the usage of this very popular node other Agent types are going to be deprecated, and on new version 1.8Agent
nodes the dropdown selection for Agent type is no longer displayed, andtoolsAgent
is used by default.On old Agent node's a deprecation warning is shown.
Also added
maxIterations
options on all Agent node types on pre-1.8Agent
nodes, this was missing fromReAct
,PlanAndExecute
andSqlAgent
.Related Linear tickets, Github issues, and Community forum posts
https://linear.app/n8n/issue/ADO-2779/feature-agent-node-get-rid-of-type-drop-down
Review / Merge checklist
release/backport
(if the PR is an urgent fix that needs to be backported)