Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(core): Rename workflowsCount to workflowCount (no-changelog) #13470

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

RicardoE105
Copy link
Contributor

@RicardoE105 RicardoE105 commented Feb 24, 2025

Summary

Title self explanatory

Review / Merge checklist

  • PR title and summary are descriptive. (conventions)
  • Docs updated or follow-up ticket created.
  • Tests included.
  • PR Labeled with release/backport (if the PR is an urgent fix that needs to be backported)

@RicardoE105 RicardoE105 changed the title rename workflowsCount to workflowCount refactor(core): Rename workflowsCount to workflowCount (changelog-log) Feb 24, 2025
@RicardoE105 RicardoE105 changed the title refactor(core): Rename workflowsCount to workflowCount (changelog-log) refactor(core): Rename workflowsCount to workflowCount (no-changelog) Feb 24, 2025
Copy link
Contributor

✅ All Cypress E2E specs passed

Copy link

cypress bot commented Feb 24, 2025

n8n    Run #9451

Run Properties:  status check failed Failed #9451  •  git commit 10898069e2: 🌳 🖥️ browsers:node18.12.0-chrome107 🤖 RicardoE105 🗃️ e2e/*
Project n8n
Branch Review rename-workflowsCount-to-workflowCount
Run status status check failed Failed #9451
Run duration 04m 31s
Commit git commit 10898069e2: 🌳 🖥️ browsers:node18.12.0-chrome107 🤖 RicardoE105 🗃️ e2e/*
Committer Ricardo Espinoza
View all properties for this run ↗︎

Test results
Tests that failed  Failures 1
Tests that were flaky  Flaky 3
Tests that did not run due to a developer annotating a test with .skip  Pending 5
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 377
View all changes introduced in this branch ↗︎

Tests for review

Failed  39-projects.cy.ts • 1 failed test

View Output Video

Test Artifacts
Projects > when starting from scratch > should move resources between projects Test Replay Screenshots Video
Failed  33-settings-personal.cy.ts • 0 failed tests

View Output

Test Artifacts
Failed  16-form-trigger-node.cy.ts • 0 failed tests

View Output

Test Artifacts
Failed  32-node-io-filter.cy.ts • 0 failed tests

View Output

Test Artifacts
Failed  8-http-request-node.cy.ts • 0 failed tests

View Output

Test Artifacts

The first 5 failed specs are shown, see all 26 specs in Cypress Cloud.

Flakiness  12-canvas.cy.ts • 1 flaky test

View Output Video

Test Artifacts
Canvas Node Manipulation and Navigation > should preserve connections after rename & node-view switch Screenshots Video
Flakiness  39-projects.cy.ts • 1 flaky test

View Output Video

Test Artifacts
Projects > when starting from scratch > should create sub-workflow and credential in the sub-workflow in the same project Test Replay Screenshots Video
Flakiness  20-workflow-executions.cy.ts • 1 flaky test

View Output Video

Test Artifacts
Workflow Executions > when workflow is saved > should render executions tab correctly Test Replay Screenshots Video

@n8n-assistant n8n-assistant bot added n8n team Authored by the n8n team ui Enhancement in /editor-ui or /design-system labels Feb 24, 2025
@n8n-assistant n8n-assistant bot added the core Enhancement outside /nodes-base and /editor-ui label Feb 24, 2025
Copy link
Contributor

✅ All Cypress E2E specs passed

Copy link

codecov bot commented Feb 24, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

📢 Thoughts on this report? Let us know!

Copy link
Contributor

⚠️ Some Cypress E2E specs are failing, please fix them before merging

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
core Enhancement outside /nodes-base and /editor-ui n8n team Authored by the n8n team ui Enhancement in /editor-ui or /design-system
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants