Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(core): Fix test runner in queue mode (no-changelog) #13479

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

burivuhster
Copy link
Contributor

Summary

This PR makes test runner work in queue mode. evaluation executions logic is almost identical to manual executions, as it also needs features like pinned data or selecting specific trigger and nodes to start executions from.
Since manual executions were offloaded to workers in queue mode, evaluation executions stopped working properly because execution data was not saved to DB before putting executions into the queue.

Related Linear tickets, Github issues, and Community forum posts

Review / Merge checklist

  • PR title and summary are descriptive. (conventions)
  • Docs updated or follow-up ticket created.
  • Tests included.
  • PR Labeled with release/backport (if the PR is an urgent fix that needs to be backported)

Copy link

codecov bot commented Feb 24, 2025

Codecov Report

Attention: Patch coverage is 33.33333% with 2 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
packages/cli/src/scaling/job-processor.ts 0.00% 1 Missing ⚠️
packages/cli/src/workflow-runner.ts 0.00% 0 Missing and 1 partial ⚠️

📢 Thoughts on this report? Let us know!

@n8n-assistant n8n-assistant bot added core Enhancement outside /nodes-base and /editor-ui n8n team Authored by the n8n team labels Feb 24, 2025
@burivuhster burivuhster marked this pull request as ready for review February 24, 2025 16:37
@burivuhster burivuhster requested a review from ivov February 25, 2025 10:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
core Enhancement outside /nodes-base and /editor-ui n8n team Authored by the n8n team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant