refactor(core): Simplify license autorenewal on leadership transition #13503
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ivov
commented
Feb 25, 2025
There was a problem hiding this comment.
Once we tear down the orchestration service we will be in a better position to test multi-main listeners.
n8n-assistant
bot
added
core
Codecov ReportAttention: Patch coverage is
📢 Thoughts on this report? Let us know! |
n8n
|
||||||||||||||||||||||||||||
| Project |
n8n
|
| Branch Review |
simplify-license-autorenewal-on-leadership-transition
|
| Run status |
|
| Run duration | 04m 42s |
| Commit |
|
| Committer | Iván Ovejero |
| View all properties for this run ↗︎ | |
| Test results | |
|---|---|
Failures
|
0
|
Flaky
|
4
|
Pending
|
5
|
Skipped
|
0
|
Passing
|
437
|
| View all changes introduced in this branch ↗︎ | |
|
✅ All Cypress E2E specs passed |
ivov
deleted the
simplify-license-autorenewal-on-leadership-transition
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
In multi-main setup, only the leader is allowed to periodically renew the license. On leadership transition, the new leader starts renewing and the former leader stops doing so.
Until now we did so by reinitializing the license manager accounting for the new instance role. This PR simplifies by updating autorenewal state without going through the full init flow.
Related Linear tickets, Github issues, and Community forum posts
https://linear.app/n8n/issue/CAT-662/simplify-license-renewal-and-reload
Review / Merge checklist
release/backport(if the PR is an urgent fix that needs to be backported)